fix: handle cases when Animation.persist() does not exist #33282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
commented
Nov 16, 2024
packages/react-components/react-motion/library/src/hooks/useAnimateAtoms.ts
Show resolved
Hide resolved
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Nov 16, 2024
ling1726
reviewed
Nov 20, 2024
packages/react-components/react-motion/library/src/hooks/useAnimateAtoms.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 21, 2024
packages/react-components/react-motion/library/src/hooks/useAnimateAtoms.ts
Outdated
Show resolved
Hide resolved
The Animation.persist() API is in our full suport matrix but was added after browsers in our partial support matrix. As no polyfill exists for this feature and it cannot be compiled away this commit explicitly handles the case when the API does not exist. When .persist() is not available we short-circuit the animation, using the existing "is reduced motion" code path to make the animation effectively instant while still firing all animation events, etc.
spmonahan
force-pushed
the
motion/persist-feature-gate
branch
from
6b1dee4 to
080f10c
Compare
github-actions
bot
modified the milestones:
November Project Cycle Q4 2024,
December Project Cycle Q4 2024
ling1726
approved these changes
Dec 19, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Animation.persist() API is in our full support matrix but was added after browsers in our partial support matrix. As no polyfill exists for this feature and it cannot be compiled away this commit explicitly handles the case when the API does not exist.
New Behavior
When .persist() is not available we short-circuit the animation, using the existing "is reduced motion" code path to make the animation effectively instant while still firing all animation events, etc.