Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-color-picker): active axis for ColorPicker #33415

Merged

Conversation

ValentinaKozlova
Copy link
Contributor

Previous Behavior

  • active axis was x by default and it caused jump of focus on ColorArea while using arrows
  • After focusing on ColorArea focus returned on it even after blur event

New Behavior

  • Set null active axis by default
  • Removed useEffect because focus works correctly without it

Copy link

github-actions bot commented Dec 6, 2024

📊 Bundle size report

✅ No changes found

Copy link

github-actions bot commented Dec 6, 2024

Pull request demo site: URL

@ValentinaKozlova ValentinaKozlova mentioned this pull request Dec 9, 2024
28 tasks
@ValentinaKozlova ValentinaKozlova merged commit b9a11c5 into microsoft:master Dec 11, 2024
16 checks passed
@ValentinaKozlova ValentinaKozlova deleted the fix/color-picker-focus branch December 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants