Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative chart bug fixes #33426

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Declarative chart bug fixes #33426

merged 6 commits into from
Dec 12, 2024

Conversation

Anush2303
Copy link
Contributor

@Anush2303 Anush2303 commented Dec 9, 2024 •
edited
Loading

Bugs fixed:

  1. Heatmap: chart crashes if colorscale array not provided in data.
  2. Sankey: if source and target does not contain nodes with same number or negative numbered nodes, chart crashes.
  3. Horizontal bar chart: Bars are overlapping.
  4. Line chart: Vertical dotted line going below x-axis

Related Issue(s)

  • Fixes #

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Pull request demo site: URL

@Anush2303 Anush2303 marked this pull request as ready for review December 10, 2024 08:19
@Anush2303 Anush2303 requested a review from a team as a code owner December 10, 2024 08:19
@Anush2303 Anush2303 marked this pull request as draft December 10, 2024 08:19
@Anush2303 Anush2303 marked this pull request as ready for review December 10, 2024 09:41
@srmukher
Copy link
Contributor

srmukher commented Dec 10, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

Can you give a description of which bugs were fixed?

AtishayMsft
AtishayMsft approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@AtishayMsft AtishayMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Anush2303 Anush2303 merged commit 97bb4b6 into master Dec 12, 2024
15 of 18 checks passed
@Anush2303 Anush2303 deleted the usr/agupta/declarativeChartBugs branch December 12, 2024 14:18
@Anush2303 Anush2303 restored the usr/agupta/declarativeChartBugs branch December 12, 2024 16:45
@Anush2303 Anush2303 deleted the usr/agupta/declarativeChartBugs branch December 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srmukher srmukher srmukher left review comments

@fabricteam fabricteam fabricteam left review comments

@AtishayMsft AtishayMsft AtishayMsft approved these changes

Assignees

@AtishayMsft AtishayMsft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anush2303 @srmukher @fabricteam @AtishayMsft