Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(chapter-1): Fix broken image URL and list indentation #629

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

shiftpx
Copy link
Contributor

@shiftpx shiftpx commented Oct 26, 2024

Specifically, creative-writing-example.png was not loading. Fixed the indentation around it and for the whole list. Removed extraneous <br> tags.

Before After
54599 10261

Specifically, _creative-writing-example.png_ was not loading. Fixed the indentation around it and for the whole list. Removed extraneous `<br>` tags.
Copy link

👋 Thanks for contributing @shiftpx! We will review the pull request and get back to you soon.

Copy link

Check Broken URLs

We have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue.

Check the file paths and associated broken URLs inside them. For more details, check our Contributing Guide.

File Full Path Issues
04-prompt-engineering-fundamentals/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst284
04-prompt-engineering-fundamentals/translations/ko/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst273
04-prompt-engineering-fundamentals/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst278
04-prompt-engineering-fundamentals/translations/ja-jp/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-yoterada298
04-prompt-engineering-fundamentals/translations/cn/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst271
04-prompt-engineering-fundamentals/translations/pt-br/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/model_io/prompts/prompt_templates/?WT.mc_id=academic-105485-koreyst277
17-ai-agents/translations/tw/README.md
#LinkLine Number
1https://python.langchain.com/docs/modules/agents/?WT.mc_id=academic-105485-koreyst41
16-open-source-models/README.md
#LinkLine Number
1https://opensource.org/osd?WT.mc_id=academic-105485-koreyst15
16-open-source-models/translations/tw/README.md
#LinkLine Number
1https://opensource.org/osd?WT.mc_id=academic-105485-koreyst15

@shiftpx
Copy link
Contributor Author

shiftpx commented Oct 26, 2024

@microsoft-github-policy-service agree

@shiftpx
Copy link
Contributor Author

shiftpx commented Oct 26, 2024

Errors in #629 (comment) are unrelated to the changes I made.

@koreyspace koreyspace merged commit 7256782 into microsoft:main Nov 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants