Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Input is changed when rerun the node after run the overall flow #1365

Merged
merged 9 commits into from
Dec 20, 2023

Conversation

lalala123123
Copy link
Contributor

@lalala123123 lalala123123 commented Dec 4, 2023

Description

node test supports dict as input.
inputs.jsonl generated by extension:

{
    "get_dict_val.output.value": {"key": "value"},
}

pf flow test --node xxx --inputs inputs.jsonl
Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Dec 4, 2023

SDK CLI Global Config Test Result zhrua/fix_node_run_with_dict

2 tests   2 ✔️  38s ⏱️
1 suites  0 💤
1 files    0

Results for commit 8d9be6d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 4, 2023

Executor Unit Test Result zhrua/fix_node_run_with_dict

600 tests   597 ✔️  45s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 8d9be6d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 4, 2023

SDK PFS E2E Test Result zhrua/fix_node_run_with_dict

  2 files    2 suites   1m 17s ⏱️
15 tests 15 ✔️ 0 💤 0
30 runs  30 ✔️ 0 💤 0

Results for commit 4e76a44.

Copy link

github-actions bot commented Dec 4, 2023

promptflow SDK CLI Azure E2E Test Result zhrua/fix_node_run_with_dict

    4 files      4 suites   2m 35s ⏱️
115 tests   97 ✔️ 18 💤 0
460 runs  388 ✔️ 72 💤 0

Results for commit 8d9be6d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 4, 2023

Executor E2E Test Result zhrua/fix_node_run_with_dict

157 tests   155 ✔️  2m 18s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit 8d9be6d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 4, 2023

SDK CLI Test Result zhrua/fix_node_run_with_dict

     12 files       12 suites   10m 48s ⏱️
   325 tests    319 ✔️   6 💤 0
1 300 runs  1 276 ✔️ 24 💤 0

Results for commit 8d9be6d.

♻️ This comment has been updated with latest results.

@lalala123123 lalala123123 marked this pull request as ready for review December 18, 2023 05:23
@lalala123123 lalala123123 requested review from a team as code owners December 18, 2023 05:23
wangchao1230
wangchao1230 previously approved these changes Dec 19, 2023
zhengfeiwang
zhengfeiwang previously approved these changes Dec 19, 2023
@lalala123123 lalala123123 merged commit 518d203 into main Dec 20, 2023
42 checks passed
@lalala123123 lalala123123 deleted the zhrua/fix_node_run_with_dict branch December 20, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Input is changed when rerun the node after run the overall flow.
3 participants