Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/promptflow/1.2.0 #1460

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Release/promptflow/1.2.0 #1460

merged 12 commits into from
Dec 14, 2023

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Dec 13, 2023

Description

Release promptflow 1.2.0: https://pypi.org/project/promptflow/1.2.0/

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Dec 13, 2023

SDK CLI Global Config Test Result release/promptflow/1.2.0

2 tests   2 ✔️  43s ⏱️
1 suites  0 💤
1 files    0

Results for commit c2ff5cd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Executor Unit Test Result release/promptflow/1.2.0

601 tests   598 ✔️  46s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit c2ff5cd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

promptflow SDK CLI Azure E2E Test Result release/promptflow/1.2.0

    4 files      4 suites   2m 3s ⏱️
115 tests   97 ✔️ 18 💤 0
460 runs  388 ✔️ 72 💤 0

Results for commit c2ff5cd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Executor E2E Test Result release/promptflow/1.2.0

156 tests   154 ✔️  2m 13s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit c2ff5cd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

SDK CLI Test Result release/promptflow/1.2.0

     12 files       12 suites   11m 2s ⏱️
   325 tests    319 ✔️   6 💤 0
1 300 runs  1 276 ✔️ 24 💤 0

Results for commit c2ff5cd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

SDK PFS E2E Test Result release/promptflow/1.2.0

  2 files    2 suites   1m 54s ⏱️
16 tests 16 ✔️ 0 💤 0
32 runs  32 ✔️ 0 💤 0

Results for commit 3a4ae58.

♻️ This comment has been updated with latest results.

0mza987 and others added 2 commits December 13, 2023 11:57
# Description

- Enable `pf run create` with local exisiting run folder.
    -`pf run create --source <path-to-run-folder>`
- Refine `pfazure run download`:
   - Download metadata of run.
   - Use thread pool to run sync functions.


# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.

---------

Co-authored-by: Zhengfei Wang <zhengfei.wang@microsoft.com>
# Description

This pull request includes several changes to improve code readability,
maintainability, and functionality. The most important changes include
refactoring code in the `_flow_operations.py` file to improve
readability and maintainability, various changes in the `utils.py` file
to improve code clarity and future modifications, and the addition of a
new class method in the `_base_executor_proxy.py` file for generating
tool metadata.

Code readability and maintainability improvements:

* <a
href="diffhunk://#diff-afdd40a5d0519512dcf9be48bd46c4caaa2291b808687de77896989af63f47e4L372-R391">`src/promptflow/promptflow/_sdk/operations/_flow_operations.py`</a>:
Refactored code to improve readability and maintainability by using the
`load_flow` function instead of directly instantiating classes. <a
href="diffhunk://#diff-afdd40a5d0519512dcf9be48bd46c4caaa2291b808687de77896989af63f47e4L372-R391">[1]</a>
<a
href="diffhunk://#diff-afdd40a5d0519512dcf9be48bd46c4caaa2291b808687de77896989af63f47e4L558-R557">[2]</a>
* <a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abR8-R19">`src/promptflow/promptflow/_sdk/_submitter/utils.py`</a>:
Various changes to improve code clarity and future code modifications.
<a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abR8-R19">[1]</a>
<a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abL174-R178">[2]</a>
<a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abR193">[3]</a>
<a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abL35-R39">[4]</a>
<a
href="diffhunk://#diff-38c78274ff4a19381a2129bfd86174d225e0d8537b48c80aa8f6feaca25083abL201-L215">[5]</a>
* <a
href="diffhunk://#diff-44ac8eeb30a630bd24987e92f8bd5a180d57a3ad067db5d937561f21771e14c5R25-R33">`src/promptflow/promptflow/batch/_base_executor_proxy.py`</a>:
Added a new class method `_get_tool_metadata` to generate the tool
metadata file for a flow.

Other important changes:

* <a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138R486-R487">`src/promptflow/promptflow/_sdk/_submitter/test_submitter.py`</a>:
Changes to improve code readability and maintainability. <a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138R486-R487">[1]</a>
<a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138L35-R35">[2]</a>
<a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138L16-R16">[3]</a>
<a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138L400-R400">[4]</a>
<a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138L416-L420">[5]</a>
<a
href="diffhunk://#diff-d9dd2c09a149b11eb54626edf065287eeb7b1a28e39719b8dd95377770f64138L471-L476">[6]</a>
* <a
href="diffhunk://#diff-339752a6e9c04159a62708efed6b385bd91b016a0f0d2edeb32024fd19886a2bR232-R235">`src/promptflow/promptflow/_sdk/entities/_flow.py`</a>:
Added a new property `language` to the `Flow` class.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [x] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [x] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Copy link

github-actions bot commented Dec 13, 2023

Test Results

       48 files         48 suites   5h 47m 19s ⏱️
  1 191 tests   1 174 ✔️   16 💤 1
14 112 runs  13 871 ✔️ 240 💤 1

For more details on these failures, see this check.

Results for commit 3a4ae58.

♻️ This comment has been updated with latest results.

# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
@github-actions github-actions bot added documentation Improvements or additions to documentation fundamental labels Dec 14, 2023
@D-W- D-W- changed the title Release/promptflow/1.2.0 (Do not merge) Release/promptflow/1.2.0 Dec 14, 2023
@D-W- D-W- merged commit 3ecc9f7 into main Dec 14, 2023
42 checks passed
@D-W- D-W- deleted the release/promptflow/1.2.0 branch December 14, 2023 11:14
@D-W- D-W- restored the release/promptflow/1.2.0 branch December 14, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli prompt flow CLI promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants