-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support default input index when collect package tools for custom-llm tool #1502
Conversation
SDK CLI Global Config Test Result chesi/support-input-index2 tests 2 ✅ 45s ⏱️ Results for commit af9a1b7. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result chesi/support-input-index702 tests 702 ✅ 41s ⏱️ Results for commit af9a1b7. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result chesi/support-input-index 4 files 4 suites 3m 14s ⏱️ Results for commit af9a1b7. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result chesi/support-input-index188 tests 185 ✅ 3m 55s ⏱️ Results for commit af9a1b7. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result chesi/support-input-index 12 files 12 suites 37m 42s ⏱️ Results for commit af9a1b7. ♻️ This comment has been updated with latest results. |
update
update update
update update add debug info add debug info add debug info add debug delete debug debug update delete debug add test collect tools from directory add debug update update delete debug delete test in promptflow-tools
update update
update
16362e2
to
168b6cb
Compare
Description
Reason
Previously, customers complained that the order of custom-llm tool inputs displayed in the UI was inconsistent with the order defined in tool interface or yaml file. This was because the UI received the inputs as a dict, which resulted in an alphabetical order display.
In this PR, we will automatically add "ui_hints": {"index": XX} to every input based on the order in tool interface or yaml file for custom_llm tool. When UI received tool inputs, they can display the inputs according to this ui_hints["index"] field to make the order consistent. Both portal and extension have completed the code change to support ui_hints["index"].
Cases which will not be corrected by this pr:
Test
For more test cases, please go to this link
custom-llm tool
built in custom-llm tool
Test cases
The behavior of the following test cases are as expected. Only custom_llm tool's inputs' order are corrected, other tool's inputs' order keep same as before.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines