Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update built-in evaluators' inputs validation logic and remove default values #2645

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Apr 3, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu requested a review from a team as a code owner April 3, 2024 20:01
@ninghu ninghu changed the title Update built-in evalualtors' inputs validation logic and remove default values Update built-in evaluators' inputs validation logic and remove default values Apr 3, 2024
nagkumar91
nagkumar91 previously approved these changes Apr 3, 2024
luigiw
luigiw previously approved these changes Apr 3, 2024
@ninghu ninghu dismissed stale reviews from luigiw and nagkumar91 via 9c311bf April 3, 2024 20:36
Copy link

github-actions bot commented Apr 3, 2024

promptflow-evals test result

12 files  12 suites   56s ⏱️
 5 tests  5 ✅ 0 💤 0 ❌
60 runs  60 ✅ 0 💤 0 ❌

Results for commit 9c311bf.

@ninghu ninghu merged commit 4275976 into main Apr 3, 2024
25 checks passed
@ninghu ninghu deleted the users/ninhu/evaluators_validation_update branch April 3, 2024 21:13
@ninghu ninghu restored the users/ninhu/evaluators_validation_update branch April 4, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants