Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection override fix #2746

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

singankit
Copy link
Member

Description

Connection override does not work when running a flow after first run.

flow = load_flow(...)

flow.context.connections = {
            "query_llm": {
                "connection": AzureOpenAIConnection(
                    api_base=model_config.api_base,
                    api_key=model_config.api_key,
                    api_version=model_config.api_version,
                    api_type="azure"
                ),
                "deployment_name": deployment_name,
            }

flow(...) # This work
flow(....) # This fails

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 11, 2024

promptflow SDK CLI Azure E2E Test Result users/singankit/connection_override_fix

  4 files    4 suites   4m 20s ⏱️
213 tests 193 ✅ 20 💤 0 ❌
852 runs  772 ✅ 80 💤 0 ❌

Results for commit e414fd0.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 11, 2024
@wangchao1230 wangchao1230 dismissed their stale review April 11, 2024 03:41

new comments

Copy link

github-actions bot commented Apr 11, 2024

Executor Unit Test Result users/singankit/connection_override_fix

778 tests   778 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e414fd0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor E2E Test Result users/singankit/connection_override_fix

238 tests   236 ✅  6m 54s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit e414fd0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Test Result users/singankit/connection_override_fix

   12 files     12 suites   48m 29s ⏱️
  573 tests   554 ✅ 19 💤 0 ❌
2 292 runs  2 216 ✅ 76 💤 0 ❌

Results for commit e414fd0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Global Config Test Result users/singankit/connection_override_fix

3 tests   3 ✅  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e414fd0.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 11, 2024
D-W-
D-W- previously approved these changes Apr 11, 2024
@singankit singankit merged commit eea9ea2 into main Apr 11, 2024
44 checks passed
@singankit singankit deleted the users/singankit/connection_override_fix branch April 11, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants