Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFS] Start pfs in foreground and log in terminal and file in debug mode #2756

Merged
merged 9 commits into from
Apr 12, 2024

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Apr 11, 2024

Description

  • pf service start --debug will start pfs in forground and print log in both terminal and pfs.log
    image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 11, 2024

promptflow SDK CLI Azure E2E Test Result dev/chenyin/pfs_foreground_in_debug

  4 files    4 suites   4m 24s ⏱️
216 tests 192 ✅ 24 💤 0 ❌
864 runs  768 ✅ 96 💤 0 ❌

Results for commit 04f362f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor Unit Test Result dev/chenyin/pfs_foreground_in_debug

778 tests   778 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 04f362f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor E2E Test Result dev/chenyin/pfs_foreground_in_debug

238 tests   236 ✅  7m 50s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 04f362f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Test Result dev/chenyin/pfs_foreground_in_debug

    4 files      4 suites   44m 29s ⏱️
  579 tests   558 ✅ 21 💤 0 ❌
2 316 runs  2 232 ✅ 84 💤 0 ❌

Results for commit 04f362f.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Global Config Test Result dev/chenyin/pfs_foreground_in_debug

3 tests   3 ✅  1m 8s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 04f362f.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 11, 2024
@YingChen1996 YingChen1996 merged commit ac82e2e into main Apr 12, 2024
42 checks passed
@YingChen1996 YingChen1996 deleted the dev/chenyin/pfs_foreground_in_debug branch April 12, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants