-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fundamental] Add CG in compliance check CI to avoid license issue #3517
Draft
zhengfeiwang
wants to merge
25
commits into
main
Choose a base branch
from
zhengfei/license-compliance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengfeiwang
changed the title
[fundamental] add workflow to check licenses compliance
[fundamental] Add workflow as CI to check licenses compliance
Jul 9, 2024
zhengfeiwang
changed the title
[fundamental] Add workflow as CI to check licenses compliance
[fundamental] Add CG in compliance check CI to avoid license issue
Jul 11, 2024
promptflow SDK CLI Azure E2E Test Result zhengfei/license-compliance0 tests 0 ✅ 0s ⏱️ Results for commit 0923bce. |
SDK CLI Global Config Test Result zhengfei/license-compliance0 tests 0 ✅ 0s ⏱️ Results for commit 0923bce. |
This reverts commit 0923bce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR targets to add CG (Component Governance, link to doc) step in compliance check, so that we can find inappropriate dependency introduced, as #3513 raises, during PR review and avoid change merged without caution.
Note that CG currently does not support detection from pyproject.toml file, so we leverage Python package toml-to-requirements to convert toml files to supported requirements.txt.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines