Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TypeError in Tracing issue with tokens that are dicts #3885

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

KronemeyerJoshua
Copy link
Contributor

Description

In the latest version of OpenAI some keys have tokens that are not ints. This is causing TypeErrors like
TypeError: unsupported operand type(s) for +: 'int' and 'dict'
This aims to handle None types and Dicts better in tracing.

Should resolve bug #3834

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@KronemeyerJoshua
Copy link
Contributor Author

@microsoft-github-policy-service agree

@apthagowda97
Copy link

Please merge this on priority!!! Production flows are failing with new Azure OpenAI GPT 4o version (2024-08-06)

src/promptflow-tracing/CHANGELOG.md Outdated Show resolved Hide resolved
@KronemeyerJoshua
Copy link
Contributor Author

@luigiw please review again to clear the flag, the changelog has been updated.

@luigiw luigiw merged commit e8641e6 into microsoft:main Dec 17, 2024
42 of 59 checks passed
@apthagowda97
Copy link

apthagowda97 commented Dec 19, 2024

Thanks for the quick fix!! Any idea on new version release ??
FYI this issues we are facing in 2024-08-06 and 2024-11-20 version of Azure OpenAI GPT 4o.

Can this be released on priority ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants