Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK/CLI] Fix encoding issue with non-English input #683

Merged
merged 7 commits into from
Oct 12, 2023
Merged

[SDK/CLI] Fix encoding issue with non-English input #683

merged 7 commits into from
Oct 12, 2023

Conversation

0mza987
Copy link
Contributor

@0mza987 0mza987 commented Oct 7, 2023

Description

To fix the encoding issue, add encoding when opening files.

#668

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@0mza987 0mza987 requested a review from a team as a code owner October 7, 2023 10:04
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:04 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:04 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:04 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:04 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:04 — with GitHub Actions Inactive
@github-actions github-actions bot added examples Improvements on examples sdk prompt flow SDK promptflow labels Oct 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

SDK CLI Global Config Test Result hod/unicode

2 tests   2 ✔️  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 0a5828e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

Executor Unit Test Result hod/unicode

    2 files      2 suites   1m 40s ⏱️
347 tests 347 ✔️ 0 💤 0 ❌
672 runs  671 ✔️ 1 💤 0 ❌

Results for commit 0a5828e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

SDK PFS E2E Test Result hod/unicode

8 tests   8 ✔️  22s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 0a5828e.

♻️ This comment has been updated with latest results.

@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:10 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

Executor E2E Test Result hod/unicode

    2 files      2 suites   6m 39s ⏱️
102 tests 100 ✔️ 2 💤 0 ❌
204 runs  198 ✔️ 6 💤 0 ❌

Results for commit d91b73f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

SDK CLI Test Result hod/unicode

    2 files      2 suites   30m 15s ⏱️
278 tests 264 ✔️ 14 💤 0 ❌
556 runs  528 ✔️ 28 💤 0 ❌

Results for commit d91b73f.

♻️ This comment has been updated with latest results.

@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:36 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:36 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:36 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:36 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 7, 2023 10:36 — with GitHub Actions Inactive
@0mza987 0mza987 mentioned this pull request Oct 7, 2023
Closed
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 03:22 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 03:22 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 03:22 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 03:22 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 03:22 — with GitHub Actions Inactive
lalala123123
lalala123123 previously approved these changes Oct 12, 2023
View reviewed changes
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:01 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:01 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:01 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:01 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:01 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 05:10 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 06:30 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 06:30 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 06:30 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 06:30 — with GitHub Actions Inactive
@0mza987 0mza987 temporarily deployed to internal October 12, 2023 06:30 — with GitHub Actions Inactive
@0mza987 0mza987 merged commit 0db2566 into main Oct 12, 2023
33 of 36 checks passed
@0mza987 0mza987 deleted the hod/unicode branch October 12, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 left review comments

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@YingChen1996 YingChen1996 YingChen1996 approved these changes

@lalala123123 lalala123123 lalala123123 approved these changes

Assignees
No one assigned
Labels
examples Improvements on examples promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0mza987 @lalala123123 @YingChen1996 @zhengfeiwang @wangchao1230