Skip to content

Commit

Permalink
Java: Fix typos in Java (#3253)
Browse files Browse the repository at this point in the history
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
  • Loading branch information
johnoliver authored Oct 23, 2023
1 parent d9520ee commit 82aeeab
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions java/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ will need to set the following environment variable:
If you are using Azure OpenAI, you will also need to set the following environment variables:

- `AZURE_OPENAI_ENDPOINT` - the Azure OpenAI endpoint found in **Keys * Endpoint** section of the Azure OpenAI service.
- `AZURE_OPENAI_API_KEY` - the Azure OpoenAI API key found in **Keys * Endpoint** section of the Azure OpenAI service.
- `AZURE_OPENAI_API_KEY` - the Azure OpenAI API key found in **Keys * Endpoint** section of the Azure OpenAI service.
- `AZURE_OPENAI_DEPLOYMENT_NAME` - the custom name you chose for your deployment when you deployed a model. It can be
found under **Resource Management > Deployments** in the Azure Portal.

Expand Down Expand Up @@ -93,7 +93,7 @@ Make sure your pull request has an objective title and a clear description expla

## License

This project is licensed under the [MIT License](LICENSE).
This project is licensed under the [MIT License](../LICENSE).

## Code of Conduct

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ void azureCognitiveSearchMemoryStoreCanSaveReferenceAsync() {
"fake-index",
"fake-text",
"fake-externalId",
"fake-exernalSourceName",
"fake-externalSourceName",
"fake-description",
"fake-additionalMetadata")
.block();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* "https://github.com/microsoft/semantic-kernel/tree/main/samples">samples</a>
* folder.
*/
public class Example02_RunnningPromptsFromFile {
public class Example02_RunningPromptsFromFile {

/**
* Imports skill 'FunSkill' stored in the samples folder and then returns the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public static void summarize(Kernel kernel) {
* @param kernel
*/
public static void TLDR(Kernel kernel) {
String propmt = """
String prompt = """
{{$input}}
Give me the TLDR in 5 words.
Expand All @@ -116,7 +116,7 @@ public static void TLDR(Kernel kernel) {
does not conflict with the First or Second Law.
""";

inlineFunction(kernel, propmt, "tldr", text);
inlineFunction(kernel, prompt, "tldr", text);
}

public static void run(OpenAIAsyncClient client) throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public enum ErrorCodes {
/// <summary>
/// Unknown error.
/// </summary>
UNKOWN_ERROR("Unknown error"),
UNKNOWN_ERROR("Unknown error"),

INVALID_FUNCTION_DESCRIPTION("Invalid function description"),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ interface Builder extends SemanticKernelBuilder<ContextVariables> {
/**
* Builds an instance with the given variables
*
* @param map Existing varibles
* @param map Existing variables
* @return an instantiation of ContextVariables
*/
Builder withVariables(Map<String, String> map);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ interface Builder {
/**
* Builds an instance with the given variables
*
* @param map Existing varibles
* @param map Existing variables
* @return an instantiation of ContextVariables
*/
WritableContextVariables build(Map<String, String> map);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public String doSomething(
}

@Test
public void nonExistantVariableCreatesError() {
public void nonExistentVariableCreatesError() {
class DoesNotExist {
@DefineSKFunction
public String doSomething(@SKFunctionParameters(name = "doesNotExist") String anInput) {
Expand Down

0 comments on commit 82aeeab

Please sign in to comment.