Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: upgrade pydantic to 2.10 #9788

Closed
eavanvalkenburg opened this issue Nov 21, 2024 · 0 comments · Fixed by #9923
Closed

Python: upgrade pydantic to 2.10 #9788

eavanvalkenburg opened this issue Nov 21, 2024 · 0 comments · Fixed by #9923
Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@eavanvalkenburg
Copy link
Member

Pydantic 2.10 has some breaking changes, those have to be fixed, preferably in a compatible way with Pydantic 2.9 so we wont have to pin.
@eavanvalkenburg eavanvalkenburg added the bug Something isn't working label Nov 21, 2024
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels Nov 21, 2024
@eavanvalkenburg eavanvalkenburg added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Nov 21, 2024
@eavanvalkenburg eavanvalkenburg linked a pull request Dec 10, 2024 that will close this issue
Python: updated pydantic 2.10.3 works again #9923
Merged
4 tasks
@eavanvalkenburg eavanvalkenburg mentioned this issue Dec 10, 2024
Merged
4 tasks
@eavanvalkenburg eavanvalkenburg moved this from Bug to Sprint: In Review in Semantic Kernel Dec 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@eavanvalkenburg
Python: updated pydantic 2.10.3 works again (#9923)
b1f4769 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Manual update to pydantic requirement, they fixed the incompatibility in
10.3 (10.<3 was broken).

We need one more fix in Pydantic 2.10, which should come in 2.10.4:
pydantic/pydantic#10910
this is the issue: pydantic/pydantic#11024
Comes into play with some of the vector stores.

So excluded 2.10 smaller then 2.10.4.

Closes #9788

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: updated pydantic 2.10.3 works again eavanvalkenburg/semantic-kernel
2 participants
@eavanvalkenburg @markwallace-microsoft