-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: updated pydantic 2.10.3 works again #9923
Merged
eavanvalkenburg
merged 25 commits into
microsoft:main
from
eavanvalkenburg:pydantic_update
Dec 12, 2024
Merged
Python: updated pydantic 2.10.3 works again #9923
eavanvalkenburg
merged 25 commits into
microsoft:main
from
eavanvalkenburg:pydantic_update
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Dec 10, 2024
eavanvalkenburg
force-pushed
the
pydantic_update
branch
from
December 10, 2024 08:06
e38e3f0
to
9613a3c
Compare
moonbox3
changed the title
Python: updated pydantic 10.3 works again
Python: updated pydantic 2.10.3 works again
Dec 10, 2024
moonbox3
approved these changes
Dec 10, 2024
eavanvalkenburg
force-pushed
the
pydantic_update
branch
from
December 10, 2024 15:50
7fde867
to
e4229b2
Compare
TaoChenOSU
reviewed
Dec 10, 2024
TaoChenOSU
approved these changes
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
eavanvalkenburg
force-pushed
the
pydantic_update
branch
from
December 11, 2024 08:03
2cc9c32
to
d9a1dad
Compare
moonbox3
approved these changes
Dec 11, 2024
moonbox3
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 11, 2024
moonbox3
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
TaoChenOSU
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
TaoChenOSU
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
TaoChenOSU
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
TaoChenOSU
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Manual update to pydantic requirement, they fixed the incompatibility in 10.3 (10.<3 was broken).
We need one more fix in Pydantic 2.10, which should come in 2.10.4: pydantic/pydantic#10910
this is the issue: pydantic/pydantic#11024
Comes into play with some of the vector stores.
So excluded 2.10 smaller then 2.10.4.
Closes #9788
Description
Contribution Checklist