Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Kernel Syntax Examples BugFix #3086

Merged
merged 15 commits into from
Oct 6, 2023

Conversation

RogerBarreto
Copy link
Member

Motivation and Context

Find and fix any potential errors in Kernel Examples code.

Description

Examples fixed with the latest changes

Contribution Checklist

@RogerBarreto RogerBarreto added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples PR: regression fix Used to track PRs that fix a regression in the main branch labels Oct 5, 2023
@RogerBarreto RogerBarreto self-assigned this Oct 5, 2023
@RogerBarreto RogerBarreto requested a review from a team as a code owner October 5, 2023 16:51
@RogerBarreto RogerBarreto enabled auto-merge October 5, 2023 16:53
@RogerBarreto RogerBarreto changed the title .Net Hotfix Examples Fix .Net Kernel Syntax Examples BugFix Oct 5, 2023
@RogerBarreto RogerBarreto added this pull request to the merge queue Oct 6, 2023
Merged via the queue into microsoft:main with commit 1217d85 Oct 6, 2023
18 checks passed
@RogerBarreto RogerBarreto deleted the hotfix/examples-fix branch October 6, 2023 15:37
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
### Motivation and Context

Find and fix any potential errors in Kernel Examples code.

### Description

Examples fixed with the latest changes

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: SergeyMenshykh <sergemenshikh@gmail.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews PR: regression fix Used to track PRs that fix a regression in the main branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants