-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Kernel Syntax Examples BugFix #3086
Merged
RogerBarreto
merged 15 commits into
microsoft:main
from
RogerBarreto:hotfix/examples-fix
Oct 6, 2023
Merged
.Net Kernel Syntax Examples BugFix #3086
RogerBarreto
merged 15 commits into
microsoft:main
from
RogerBarreto:hotfix/examples-fix
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto hotfix/examples-fix
RogerBarreto
added
bug
Something isn't working
PR: ready for review
All feedback addressed, ready for reviews
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
samples
PR: regression fix
Used to track PRs that fix a regression in the main branch
labels
Oct 5, 2023
RogerBarreto
changed the title
.Net Hotfix Examples Fix
.Net Kernel Syntax Examples BugFix
Oct 5, 2023
markwallace-microsoft
approved these changes
Oct 5, 2023
SergeyMenshykh
approved these changes
Oct 6, 2023
dmytrostruk
approved these changes
Oct 6, 2023
markwallace-microsoft
approved these changes
Oct 6, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context Find and fix any potential errors in Kernel Examples code. ### Description Examples fixed with the latest changes ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: SergeyMenshykh <sergemenshikh@gmail.com> Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
PR: regression fix
Used to track PRs that fix a regression in the main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Find and fix any potential errors in Kernel Examples code.
Description
Examples fixed with the latest changes
Contribution Checklist