Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Hide Memory Collection types for internal usage only #3175

Merged
merged 3 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Plugins/Plugins.Memory/Collections/MinHeap.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.SemanticKernel.Plugins.Memory.Collections;
/// Implements the classic 'heap' data structure. By default, the item with the lowest value is at the top of the heap.
/// </summary>
/// <typeparam name="T">Data type.</typeparam>
public sealed class MinHeap<T> : IEnumerable<T> where T : IComparable<T>
internal sealed class MinHeap<T> : IEnumerable<T> where T : IComparable<T>
{
private const int DefaultCapacity = 7;
private const int MinCapacity = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.SemanticKernel.Plugins.Memory.Collections;
/// Structure for storing data which can be scored.
/// </summary>
/// <typeparam name="T">Data type.</typeparam>
public readonly struct ScoredValue<T> : IComparable<ScoredValue<T>>, IEquatable<ScoredValue<T>>
internal readonly struct ScoredValue<T> : IComparable<ScoredValue<T>>, IEquatable<ScoredValue<T>>
{
/// <summary>
/// Initializes a new instance of the <see cref="ScoredValue{T}"/> struct.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.SemanticKernel.Plugins.Memory.Collections;
/// Automatically flushes out any not in the top N.
/// By default, items are not sorted by score until you call <see cref="TopNCollection{T}.SortByScore"/>.
/// </summary>
public class TopNCollection<T> : IEnumerable<ScoredValue<T>>
internal sealed class TopNCollection<T> : IEnumerable<ScoredValue<T>>
{
private readonly MinHeap<ScoredValue<T>> _heap;
private bool _sorted = false;
Expand Down
dmytrostruk marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

This file was deleted.

Loading