Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Remove Kernel.Builder #3180

Merged
merged 7 commits into from
Oct 24, 2023
Merged

.Net: Remove Kernel.Builder #3180

merged 7 commits into from
Oct 24, 2023

Conversation

feiyun0112
Copy link
Contributor

@feiyun0112 feiyun0112 commented Oct 14, 2023

Resolves: #3169
Use new KernelBuilder() instead of Kernel.Builder

@feiyun0112 feiyun0112 requested a review from a team as a code owner October 14, 2023 06:00
@shawncal shawncal added docs and tests Improvements or additions to documentation .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples memory connector labels Oct 14, 2023
Copy link
Member

@dmytrostruk dmytrostruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feiyun0112 Thanks a lot!
I left a couple of comments to resolve.

dotnet/src/SemanticKernel.Core/Kernel.cs Outdated Show resolved Hide resolved
Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts, LGTM

samples/dotnet/OpenApiPluginsExample/Program.cs Outdated Show resolved Hide resolved
@RogerBarreto RogerBarreto added the PR: breaking change Pull requests that introduce breaking changes label Oct 24, 2023
@dmytrostruk dmytrostruk removed the PR: breaking change Pull requests that introduce breaking changes label Oct 24, 2023
@RogerBarreto RogerBarreto added this pull request to the merge queue Oct 24, 2023
Merged via the queue into microsoft:main with commit ba40209 Oct 24, 2023
19 checks passed
@feiyun0112 feiyun0112 deleted the issues-3169 branch October 25, 2023 02:41
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
microsoft#3169 
Use `new KernelBuilder()` instead of `Kernel.Builder`

---------

Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Can we remove Kernel.Builder?
4 participants