.Net: Obsolete the useless SetDefaultFunctionCollection #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ISKFunction` exposes a `SetDefaultFunctionCollection`. On all implementations it's either a nop or just delegates to the same interface method on a wrapped object. The one exception to that is `SemanticFunction`, which stores the argument into a field _that then is never used_.
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Oct 16, 2023
SergeyMenshykh
approved these changes
Oct 16, 2023
|
FYI: need re-approval after merge conflict resolution in this commit: 39dbd01 |
SergeyMenshykh
approved these changes
Oct 16, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Description `ISKFunction` exposes a `SetDefaultFunctionCollection`. On all implementations it's either a nop or just delegates to the same interface method on a wrapped object. The one exception to that is `SemanticFunction`, which stores the argument into a field _that then is never used_. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ISKFunctionexposes aSetDefaultFunctionCollection. On all implementations it's either a nop or just delegates to the same interface method on a wrapped object. The one exception to that isSemanticFunction, which stores the argument into a field that then is never used.Contribution Checklist