Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Avoid a few unnecessary Dictionary allocations in Abstractions #3188

Merged
merged 1 commit into from
Oct 16, 2023
Merged

.Net: Avoid a few unnecessary Dictionary allocations in Abstractions #3188

merged 1 commit into from
Oct 16, 2023

Conversation

stephentoub
Copy link
Member

Contribution Checklist

@stephentoub stephentoub requested a review from a team as a code owner October 15, 2023 03:37
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel.core labels Oct 15, 2023
@github-actions github-actions bot changed the title Avoid a few unnecessary Dictionary allocations in Abstractions .Net: Avoid a few unnecessary Dictionary allocations in Abstractions Oct 15, 2023
@stephentoub stephentoub added this pull request to the merge queue Oct 16, 2023
Merged via the queue into microsoft:main with commit 08ebc25 Oct 16, 2023
20 checks passed
@stephentoub stephentoub deleted the avoiddictalloc branch October 16, 2023 13:16
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
@stephentoub @SOE-YoungS
.Net: Avoid a few unnecessary Dictionary allocations in Abstractions (m…
55bbbc0 
…icrosoft#3188)

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees
No one assigned
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @SergeyMenshykh @markwallace-microsoft @shawncal