Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: added parameter to control which context is used for the function call #3226

Closed
wants to merge 5 commits into from

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Small improvement in the function calling setup, this allows you to control the context used during the function call, if you have functions that depend on static context (like text_memory_skill with the collection name) then you need the existing context with the additional parameters, this is now possible. The default is that a new context is created and used, same as before.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner October 18, 2023 08:38
@shawncal shawncal added the python Pull requests for the Python Semantic Kernel label Oct 18, 2023
Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me.

Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants