-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Issue Fix - Add FunctionResponse to ChatStreaming interfaces #3246
Merged
RogerBarreto
merged 11 commits into
microsoft:main
from
RogerBarreto:issues/fix-3198-2730-2
Nov 1, 2023
Merged
.Net Issue Fix - Add FunctionResponse to ChatStreaming interfaces #3246
RogerBarreto
merged 11 commits into
microsoft:main
from
RogerBarreto:issues/fix-3198-2730-2
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerBarreto
added
enhancement
PR: feedback to address
Waiting for PR owner to address comments/questions
PR: ready for review
All feedback addressed, ready for reviews
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
labels
Oct 20, 2023
RogerBarreto
removed
the
PR: feedback to address
Waiting for PR owner to address comments/questions
label
Oct 20, 2023
SergeyMenshykh
approved these changes
Oct 24, 2023
RogerBarreto
added
the
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
label
Nov 1, 2023
dmytrostruk
approved these changes
Nov 1, 2023
@RogerBarreto it seems that when the chat completion call returns just text and no function call to be invoked - the current code will just throw a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolves #3198
Today we can't call functions using streaming, this change allows it to be used.
The current approach will require the stream to be buffered while listening to a potential function call.
The example shows how that will be achieved.
Remark: Calling
GetStreamingFunctionResponseAsync()
will buffer the stream to capture the full function call definition, use it after all the streaming messages were flushed out.Description
Allows streaming interfaces to get the function result.
This is a simplified approach (Buffer the streaming of a function call request until it's complete). Using the FunctionCall
Contribution Checklist