.Net Removing IPlan interface #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerBarreto
added
.NET
markwallace-microsoft
approved these changes
Oct 24, 2023
dmytrostruk
reviewed
Oct 24, 2023
RogerBarreto
added
the
PR: ready to merge
dmytrostruk
reviewed
Oct 24, 2023
dmytrostruk
approved these changes
Oct 24, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context IPlan interface has not definition and all Plan implementations actually implement ISKFunction members. Currently there is no need to have this as a `Flag interface`. ### Description Removing `IPlan` interface and pointing all its dependencies to `ISKFunction` directly. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
IPlan interface has not definition and all Plan implementations actually implement ISKFunction members.
Currently there is no need to have this as a
Flag interface.Description
Removing
IPlaninterface and pointing all its dependencies toISKFunctiondirectly.Contribution Checklist