.Net: Stop setting upper bound on nuget references #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
dmytrostruk
approved these changes
Nov 25, 2024
RogerBarreto
approved these changes
Nov 25, 2024
4 tasks
|
I'm surprised this is considered an anti-pattern. Having an upper bound on the YamlDotNet reference would have let me discover issue #9051 at package update time instead of at runtime. And I'd much rather discover it at package update time. |
|
Reactively set upper bounds, when there are known breaking changes, are appropriate: it's why they exist. Pre-emptively set upper bounds, when there's no known compat issue, are not appropriate, and that's the case here. There's no breaking change here: all this upper bound did is ensure the consumer will have upgrade problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an anti-pattern, blocking developers from upgrading.
#9802