Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant null check in ComputeStringHash #4420

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

remove redundant null check in ComputeStringHash #4420

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6786dd0
remove redundant null check in ComputeStringHash
SimonCropp Dec 21, 2024
60f7b0e
Merge branch 'main' into remove-redundant-null-check-in-ComputeString…
Evangelink Dec 23, 2024
782576e
Merge branch 'main' into remove-redundant-null-check-in-ComputeString…
SimonCropp Dec 23, 2024
dbb3d75
Merge remote-tracking branch 'upstream/main' into remove-redundant-nu…
SimonCropp Dec 24, 2024
570abc6
Update FNV1HashHelper.cs
SimonCropp Dec 24, 2024
111b35a
Merge branch 'main' into remove-redundant-null-check-in-ComputeString…
Evangelink Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions src/Platform/Microsoft.Testing.Extensions.HangDump/Helpers/FNV1HashHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,6 @@ internal static class FNV_1aHashHelper
/// Computes a hash of the string using the FNV-1a algorithm.
/// Used by Roslyn.
/// </summary>
public static uint ComputeStringHash(string s)
{
uint num = default;
if (s != null)
{
num = 2166136261u;
int num2 = 0;
while (num2 < s.Length)
{
num = (s[num2] ^ num) * 16777619;
num2++;
}
}

return num;
}
public static uint ComputeStringHash(string input) =>
input.Aggregate(2166136261u, (current, ch) => (ch ^ current) * 16777619);
}
Loading