Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTEST0037 (proper assert analyzer): Don't report for user defined equality operators #4456

Conversation

Youssef1313
Copy link
Member

Fixes #4414

@Youssef1313 Youssef1313 requested a review from Copilot December 27, 2024 07:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if the user operators are in the base class?

@Youssef1313
Copy link
Member Author

I think it should. It should be the compiler responsibility to give us the correct OperatorMethod with the correct MethodKind.

@Evangelink Evangelink enabled auto-merge (squash) December 27, 2024 14:28
@Evangelink Evangelink disabled auto-merge December 27, 2024 14:28
@Evangelink Evangelink merged commit f70bdd9 into microsoft:main Dec 27, 2024
9 of 11 checks passed
@Youssef1313 Youssef1313 deleted the mstest0037-proper-assert-user-defined-operator branch December 27, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSTEST0037 testing operators == and !=
2 participants