[Not Ready] [typespec-vscode] Add autocomplete of model properties for union type #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
RodgeFu
reviewed
Jan 8, 2025
| @@ -2617,7 +2617,7 @@ export function createChecker(program: Program, resolver: NameResolver): Checker | |||
|
|
|||
| function getReferencedModel( | |||
| propertyNode: ObjectLiteralPropertyNode | ModelPropertyNode, | |||
| ): Model | undefined { | |||
| ): Model | Model[] | undefined { | |||
There was a problem hiding this comment.
what if it's a model union with other type?
There was a problem hiding this comment.
More discussion is needed
There was a problem hiding this comment.
the parameter is a property, so the referenced type must be a model or some model, isn't it?
There was a problem hiding this comment.
you can use return Model[]
RodgeFu
reviewed
Jan 13, 2025
| @@ -2679,13 +2680,29 @@ export function createChecker(program: Program, resolver: NameResolver): Checker | |||
| ) { | |||
| path.unshift({ propertyName: node.id.sv }); | |||
| } | |||
| if (node.kind === SyntaxKind.ObjectLiteral) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #4024
add code and tests