make the test project individually for each cadl ranch project #5570
Conversation
ArcturusZhang
added
the
emitter:client:csharp
| @@ -219,5 +225,185 @@ private Task MultiBinaryParts(bool hasPicture) => Test(async (host) => | |||
| var response = await new MultiPartClient(host, null).GetFormDataClient().MultiBinaryPartsAsync(content, content.ContentType, null); | |||
| Assert.AreEqual(204, response.GetRawResponse().Status); | |||
| }); | |||
|
|
|||
| internal partial class MultiPartFormDataBinaryContent : BinaryContent | |||
There was a problem hiding this comment.
I have to copy this here because despite this is generated, it is internal.
We cannot use internal any more in this structure.
There was a problem hiding this comment.
Why not? How did it work before? Were we using InternalsVisibleTo?
|
API change check API changes are not detected in this pull request. |
| } | ||
| } | ||
| }); | ||
| // [CadlRanchTest] |
There was a problem hiding this comment.
Why are these commented out?
There was a problem hiding this comment.
because its corresponding source code project has an issue to compile: #5566
There was a problem hiding this comment.
somehow i cannot reproduce the issue :( or it initially does not have it. I will close it and restore this test case
| @@ -90,11 +90,6 @@ | |||
| "commandName": "Executable", | |||
| "executablePath": "$(SolutionDir)/../dist/generator/Microsoft.Generator.CSharp.exe" | |||
| }, | |||
| "http-parameters-spread": { | |||
There was a problem hiding this comment.
What happened to these?
| private static bool IsProtocolMethod(MethodInfo method) | ||
| => method.GetParameters().Any(parameter => parameter.ParameterType.Equals(typeof(BinaryContent))); | ||
| } | ||
| // public class SpreadTests : CadlRanchTestBase |
There was a problem hiding this comment.
Can you clarify why these are commented out?
There was a problem hiding this comment.
Here is an issue for this: #5565
|
|
||
| namespace TestProjects.CadlRanch.Tests.Http.Resiliency.SrvDriven.V2 | ||
| { | ||
| public partial class SrvDrivenV2Tests : CadlRanchTestBase |
There was a problem hiding this comment.
Need to retain these tests.
There was a problem hiding this comment.
Here is the issue: #5567
| @@ -21,10 +21,10 @@ | |||
| <ProjectReference Include="..\..\Microsoft.Generator.CSharp\test\common\Microsoft.Generator.CSharp.Tests.Common.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <!-- <ItemGroup> | |||
There was a problem hiding this comment.
well I meant to remove them. I will update.
Fixes #5564