Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ConditionalRequestHeaderTests.cs #5586

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update ConditionalRequestHeaderTests.cs #5586

merged 2 commits into from
Jan 14, 2025
+3 −3

Conversation

nisha-bhatia
Copy link
Contributor

@nisha-bhatia nisha-bhatia commented Jan 13, 2025 •
edited
Loading

Resolves: #5530

@nisha-bhatia
Copy link
Contributor Author

.\Test-CadlRanch.ps1 special-headers/conditional-request

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 13, 2025
@JoshLove-msft JoshLove-msft self-requested a review January 13, 2025 21:55
JoshLove-msft
JoshLove-msft reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the tests are running, looks like the tests are now failing. Need to debug why that is.

@nisha-bhatia nisha-bhatia added this pull request to the merge queue Jan 14, 2025
Merged via the queue into microsoft:main with commit f260ff0 Jan 14, 2025
21 checks passed
@nisha-bhatia nisha-bhatia deleted the nibhati-provider branch January 14, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special Headers tests not showing as passing in dashboard
3 participants
@nisha-bhatia @ArcturusZhang @JoshLove-msft