Make camel case json converter public #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanToth3
requested changes
Nov 12, 2024
src/Microsoft.ServiceHub.Framework/NodeToManagedServiceJsonRpcDescriptor.cs
Outdated
Show resolved
Hide resolved
|
Let's hold off on checking this in until we're sure we've got this scenario working |
AArnott
reviewed
Nov 12, 2024
| /// A <see cref="ServiceJsonRpcDescriptor"/> derived type that applies camelCase naming transforms to method and event names | ||
| /// and trims off any trailing "Async" suffix. | ||
| /// </summary> | ||
| public class CamelCaseTransformingDescriptor : ServiceJsonRpcDescriptor |
There was a problem hiding this comment.
Something to consider: camel case transformation is just one aspect of a descriptor. And one cannot mix and match derived types to get one descriptor with all the behaviors one wants. This is why ServiceJsonRpcDescriptor has several options within itself.
Consider making camel case behavior a separate class or utility that can be added into a descriptor instance, in a way that supports mixing in other options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.