-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed capitalization of "Python" in user-facing text #390
Conversation
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
Hi @HVbajoria! Thanks for your interesting in contributing 😊 We are reserving issues with the ghc-osd tag to the Open Source Day event happening on September 22nd. I'll add explicit comments to all of these reserved issues to avoid a similar situation like this, but if the issue is still open past the event with no one assigned to it, I can re-assign you! |
Hi @luabud, |
@HVbajoria Can you address the merge conflicts? |
Hello @karthiknadig, |
package.nls.json
Outdated
"settings.showNotifications.description": "Controls when notifications are shown by this extension.", | ||
"settings.showNotifications.off.description": "All notifications are turned off, any errors or warning are still available in the logs.", | ||
"settings.showNotifications.onError.description": "Notifications are shown only in the case of an error.", | ||
"settings.showNotifications.onWarning.description": "Notifications are shown for errors and warnings.", | ||
"settings.showNotifications.always.description": "Notifications are shown for anything that the server chooses to show.", | ||
"settings.includeStdLib.description": "Controls whether to filter out files from standard library from being linted." | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last line is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please guide me which line is missing?
Because when I compared it with current file in the repository all the lines were present.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a newline after the last }
. You can use Prettier extension to format this.
@@ -91,7 +91,6 @@ def _handler(_params): | |||
|
|||
|
|||
def test_interpreter(): | |||
"""Test linting using specific python path.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include this text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @karthiknadig,
Could you please guide me which text should I add because the function def _handler(_params): is already present at line 109?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have removed: """Test linting using specific python path."""
that was under def test_interpreter():
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I have added back the comment.
Could you please check once?
@HVbajoria It looks like there are few more merge conflicts. Sorry about this. |
Hello @karthiknadig |
I am creating this pull request to close #389 issue.
I have checked the files and capitalized "Python" wherever necessary.
Could you please check once if any changes are required?
Would be more than happy to learn and make it.
Regards,
Harshavardhan Bajoria