-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use document
role for chat responses on windows/linux
#236636
base: main
Are you sure you want to change the base?
Conversation
also cc @Tyriar in case you have any thoughts here |
@@ -24,7 +25,7 @@ export class ChatAccessibilityProvider implements IListAccessibilityProvider<Cha | |||
} | |||
|
|||
getRole(element: ChatTreeItem): AriaRole | undefined { | |||
return 'listitem'; | |||
return isMacintosh ? 'listitem' : 'document'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For mac, using document vs listitem would limit navigation flexibility
What do you mean by that? voiceover handles it differently?
I'll yield to your judgement for this, but I thought that we generally don't use 'document' because of the downsides you mention. Do we use it in other places in VS Code?
Could you add a comment about this in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using document role is too restrictive with voiceover. It would make navigation within the element challenging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to talk through this with JooYoung tomorrow
@meganrogge I think we need to test this PR with NVDA and JAWS to see if they behave as expected. I was wondering if users would still be able to navigate between next and previous responses in the Chat thread. Users may want to use Up/DownArrows to navigate through response items and hit Enter to trigger the "document" view. ESC to go back to the list view. This concept aligns with Outlook's mail preview list (Up/DownArrows) -> displaying full content (with Enter) -> going back to the preview list (via ESC). |
fix #228599
For mac, using
document
vslistitem
would limit navigation flexibility, so we will stick withlistitem
.Using
document
for windows/linux offers several advantages:Some downsides:
listitem
might reduce understanding of its context in the conversation hierarchy.role=document
may require users to switch out of reading mode to interact with buttons or links, adding friction.cc @jooyoungseo and @rperez030