Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Make a Copy Here' in File Actions #236781

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Astabol
Copy link

@Astabol Astabol commented Dec 21, 2024

'Make a Copy Here' is added in File Actions.
Functionality: If user clicks on the action it will copy the file/directory in the same directory.

Adding Screenshot:
image

It is a new action, which is combination of Copy and Paste

Thank You

@Astabol
Copy link
Author

Astabol commented Dec 21, 2024

@microsoft-github-policy-service agree

@Astabol
Copy link
Author

Astabol commented Dec 23, 2024

Hello @lramos15,
Anything you want to add here?
Thanks

Copy link

@velara3 velara3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine but it looks like it may copy the file or file path into the clipboard. Does it copy to the clipboard? if so the name might be better as "copy here" or "copy and paste here". If it's possible to duplicate the file without using the clipboard then you could use the phrase "duplicate" instead of "make a copy here" but that might involve writing more or different code.

@Astabol
Copy link
Author

Astabol commented Dec 25, 2024

Hello, It is using clipboardService so its copying the file path into the clipboard. But I noticed that the content of the clipboard is not available outside of VS Code.

For this feature the let the name like this("duplicate" or "make a copy here) only because it will be ambiguous to have "Copy Here" and "Duplicate" options in File Action. Please let me know your opinion. Thanks

@gjsjohnmurray
Copy link
Contributor

I think this should be contributed as a extension instead of being imposed on everyone's context menu.

@Astabol
Copy link
Author

Astabol commented Dec 27, 2024

Hello, Reason why this is proposed to reflect everyone's File Action because it should be a feature of the File Action. so, anyone can make a copy or duplicate the file/directory without installing any Extension.
Hope you are getting the point!

Thank You

Copy link

@velara3 velara3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would change the label to, "Duplicate" to go with the modern UI nomenclature but that can be done later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants