Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Add Apache.maven #189469

Closed

Conversation

soroshsabz
Copy link
Contributor

@soroshsabz soroshsabz commented Nov 7, 2024

ITNOA

This PR add maven to winget

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@soroshsabz
Copy link
Contributor Author

@vedantmgoyal9 I need a little help

when I try to test this new manifest, I see below log in install stage

> winget install --manifest 3.9.9 --ignore-local-archive-malware-scan

Found Apache Maven [Apache.Maven] Version 3.9.9
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Archive scan detected malware. Proceeding due to --ignore-local-archive-malware-scan
Extracting archive...
Successfully extracted archive
Starting package install...
Command line alias added: "mvn"
Successfully installed

after install successfully, I can see mvn symbolic link in below

    Directory: C:\Users\sooro\AppData\Local\Microsoft\WinGet\Links

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
la---           11/7/2024  7:47 PM              0 mvn.exe -> C:\Users\sooro\AppData\Local\Microsoft\WinGet\Packages\Apa
                                                  che.Maven__DefaultSource\apache-maven-3.9.9\bin\mvn.cmd

My first question is, why generate mvn.exe? I want to see mvn.cmd

another problem is if I run original file like below

C:\Users\sooro\AppData\Local\Microsoft\WinGet\Packages\Apache.Maven__DefaultSource\apache-maven-3.9.9\bin\mvn.cmd

everything is ok

but if I run empty mvn in shell, I see one error and then see another window that show original maven logs

image

How to resolve this?

@soroshsabz
Copy link
Contributor Author

@denelon Do you can review my PR? and see my question?

thanks

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 7, 2024
- Architecture: neutral
NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: apache-maven-3.9.9/bin/mvn.cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMD files are not allowed by policy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trenly maven publish officially mvn.cmd for windows, How to can I do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot. This repository does not allow any scripts to be used as installers or executables as a security policy

@Trenly
Copy link
Contributor

Trenly commented Nov 7, 2024

[Policy] Scripted Application

@microsoft-github-policy-service microsoft-github-policy-service bot added the Scripted-Application This package appears to be a PS1, BAT, or other scripted (not-compiled) application. label Nov 7, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Nov 7, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Nov 7, 2024
@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Nov 23, 2024
@denelon denelon closed this Dec 18, 2024
@soroshsabz
Copy link
Contributor Author

@denelon why close this PR?

@denelon
Copy link
Contributor

denelon commented Dec 18, 2024

.cmd isn't currently allowed due to our policies for the community repository.

I'm talking with some of our security folks about the possibility of supporting them in addition to .exe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. New-Package Scripted-Application This package appears to be a PS1, BAT, or other scripted (not-compiled) application. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Apache Maven
6 participants