-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Add Apache.maven #189469
[feat]: Add Apache.maven #189469
Conversation
/AzurePipelines run |
/AzurePipelines run |
/AzurePipelines run |
@vedantmgoyal9 I need a little help when I try to test this new manifest, I see below log in install stage
after install successfully, I can see mvn symbolic link in below
My first question is, why generate mvn.exe? I want to see mvn.cmd another problem is if I run original file like below
everything is ok but if I run empty mvn in shell, I see one error and then see another window that show original maven logs How to resolve this? |
@denelon Do you can review my PR? and see my question? thanks |
/AzurePipelines run |
- Architecture: neutral | ||
NestedInstallerType: portable | ||
NestedInstallerFiles: | ||
- RelativeFilePath: apache-maven-3.9.9/bin/mvn.cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMD files are not allowed by policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly maven publish officially mvn.cmd for windows, How to can I do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot. This repository does not allow any scripts to be used as installers or executables as a security policy
[Policy] Scripted Application |
/AzurePipelines run |
[Policy] Blocking-Issue |
@denelon why close this PR? |
.cmd isn't currently allowed due to our policies for the community repository. I'm talking with some of our security folks about the possibility of supporting them in addition to .exe. |
ITNOA
This PR add maven to winget
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow