Feature: sovereign clouds #955
Conversation
|
|
||
| const storageKey = 'cloud'; | ||
|
|
||
| export const clouds: ICloud[] = [ |
There was a problem hiding this comment.
Add comment that tells people that this is where new clouds are added
…ftgraph/microsoft-graph-explorer-v4 into feature/sovereign-clouds
|
SonarCloud Quality Gate failed. |
|
|
||
| const initialState: ICloud = globalCloud; | ||
|
|
||
| export function cloud(state = initialState, action: IAction): ICloud { |
There was a problem hiding this comment.
Suggestion: Can we add a test for this reducer?
| import { IAction } from '../../../types/action'; | ||
| import { SET_ACTIVE_CLOUD_SUCCESS } from '../redux-constants'; | ||
|
|
||
| export function setActiveCloud(response: object): IAction { |
There was a problem hiding this comment.
Suggestion: Can we add a test for this action?
| msalApplication.logout({ | ||
| authority: this.getAuthority() | ||
| }); | ||
| // msalApplication.logoutRedirect(); |
There was a problem hiding this comment.
this must be a stray comment :)
| @@ -50,7 +50,10 @@ export class AuthenticationWrapper implements IAuthenticationWrapper { | |||
|
|
|||
| public logOut() { | |||
| this.deleteHomeAccountId(); | |||
| msalApplication.logoutRedirect(); | |||
| msalApplication.logout({ | |||
There was a problem hiding this comment.
The logout function is deprecated in msal. We can use the logoutRedirect function in place of this
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-955.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-955.centralus.azurestaticapps.net |
| } | ||
|
|
||
| private canAccessChinaCloud() { | ||
| return geLocale === 'en-US'; |
There was a problem hiding this comment.
I was using this when sovereign clouds in different countries was something to support.
I would use the locale to match the clouds I had. So that if a cloud for the region exists I would suggest to the user that they can opt in to using another cloud
There was a problem hiding this comment.
This specific line was tied specifically to the China cloud.. I used en_Us for demos
There was a problem hiding this comment.
I don't believe we can use locale to determine anything reliable regarding what clouds a user wants to be able to use.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-955.centralus.azurestaticapps.net |
|
SonarCloud Quality Gate failed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| const { emailAddress }: any = this.profile; | ||
| return (emailAddress && emailAddress.includes('.onmicrosoft.com')); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-955.centralus.azurestaticapps.net |
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-955.centralus.azurestaticapps.net |
Overview
Brings in the sovereign clouds feature (Closes #868)
Enables support for the canary environment (Closes #584)
Updates the Chinese version to the latest GE (Closes #614)
Demo
Notes
Testing Instructions
China cloud
Canary