feat: move electron to peer dependency (#3046)

move electron to a peer dependency, this is not a breaking change as projects implementing electron applications specify the version of electron that they use as a devDependency by convention. The version range allowed is very wide and covers the old version that we were using up to the current version of electron.

fix: make scope aware requests work for electron apps
  adds support for passing approved scopes to front end via context bridge

package.json

@@ -156,8 +156,5 @@
       "pre-commit": "npm run prettier:check && npm run lint"
     }
   },
-  "resolutions": {
-    "responselike": "2.0.0"
-  },
   "packageManager": "yarn@3.6.3"
 }

packages/providers/mgt-electron-provider/package.json

@@ -44,13 +44,15 @@
   "dependencies": {
     "@azure/msal-node": "^1.0.3",
     "@microsoft/mgt-element": "*",
-    "@microsoft/microsoft-graph-client": "3.0.2",
-    "electron": "^11.0.2"
+    "@microsoft/microsoft-graph-client": "3.0.2"
+  },
+  "peerDependencies": {
+    "electron": ">=11.0.2 <29.0.0"
+  },
+  "devDependencies": {
+    "electron": "^28.2.2"
   },
   "publishConfig": {
     "directory": "dist"
-  },
-  "resolutions": {
-    "responselike": "2.0.0"
   }
-}
+}

packages/providers/mgt-electron-provider/src/Authenticator/ElectronAuthenticator.ts

@@ -18,7 +18,7 @@ import {
   SilentFlowRequest
 } from '@azure/msal-node';
 import { AuthenticationProviderOptions } from '@microsoft/microsoft-graph-client';
-import { GraphEndpoint } from '@microsoft/mgt-element';
+import { arraysAreEqual, GraphEndpoint } from '@microsoft/mgt-element';
 import { BrowserWindow, ipcMain } from 'electron';
 import { CustomFileProtocolListener } from './CustomFileProtocol';
 import { REDIRECT_URI, COMMON_AUTHORITY_URL } from './Constants';
@@ -197,6 +197,15 @@ export class ElectronAuthenticator {
   private static authInstance: ElectronAuthenticator;
 
   private _approvedScopes: string[];
+  protected get approvedScopes(): string[] {
+    return this._approvedScopes;
+  }
+  protected set approvedScopes(value: string[]) {
+    if (!arraysAreEqual(value, this._approvedScopes)) {
+      this._approvedScopes = value;
+      this.mainWindow.webContents.send('approvedScopes', value);
+    }
+  }
 
   /**
    * Creates an instance of ElectronAuthenticator.
@@ -346,7 +355,7 @@ export class ElectronAuthenticator {
       authResponse = await this.getTokenSilent(request, scopes);
     }
     if (authResponse) {
-      this._approvedScopes = authResponse.scopes;
+      this.approvedScopes = authResponse.scopes;
       return authResponse.accessToken;
     }
     return undefined;
@@ -410,7 +419,7 @@ export class ElectronAuthenticator {
    */
   private async setAccountFromResponse(response: AuthenticationResult) {
     if (response) {
-      this._approvedScopes = response.scopes;
+      this.approvedScopes = response.scopes;
       this.account = response?.account || undefined;
     } else {
       this.account = await this.getAccount();

packages/providers/mgt-electron-provider/src/Provider/ElectronContextBridgeProvider.ts

@@ -25,6 +25,7 @@ export interface IContextBridgeImpl {
   token: (options?: AuthenticationProviderOptions) => Promise<string>;
   login: () => Promise<void>;
   logout: () => Promise<void>;
+  approvedScopes: (callback: (event: IpcRendererEvent, approvedScopes: string[]) => void) => void;
 }
 
 /**
@@ -72,6 +73,9 @@ export class ElectronContextBridgeProvider extends IProvider {
         Providers.globalProvider.setState(ProviderState.SignedOut);
       }
     });
+    this.contextBridge.approvedScopes((_event, approvedScopes) => {
+      Providers.globalProvider.approvedScopes = approvedScopes;
+    });
   }
 
   /**