-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render cta for unsupported content #2663
Conversation
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
packages/mgt-chat/src/components/UnsupportedContent/UnsupportedContent.tsx
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/components/UnsupportedContent/UnsupportedContent.tsx
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/components/UnsupportedContent/UnsupportedContent.tsx
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/components/ManageChatMembers/ListChatMembers.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
…raph-toolkit into unsupported-content
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
…raph-toolkit into unsupported-content
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
A couple of comments. Might be related to design / specs that were a bit unclear. Let me know if we prefer managing them as part of this PR or as part of a set of bugs:
"body": {
"contentType": "html",
"content": "<hr><p>gdffdgdfg</p><p>dfg</p><h1>dfgdfgdfg</h1><p>dfgd</p><p style=\"margin-left:40px\">fgdfgdfgdfg</p><p>dfgdfg</p><p> </p><p> </p><table itemprop=\"copy-paste-table\"><tbody><tr><td><p> </p></td><td> </td><td> </td><td> </td><td> </td><td> </td></tr><tr><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr><tr><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr><tr><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr><tr><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td></tr></tbody></table><p> </p><p> </p>"
} |
@sebastienlevert I have updated the first 2 issues. As for the rendering as plain text one, that is as a result of the MessageThreads component not currently supporting a way for customizing the ouput when you have unsupported content. It is a dirty hack that uses |
packages/mgt-chat/src/components/ManageChatMembers/ListChatMembers.tsx
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/statefulClient/StatefulGraphChatClient.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@musale Not sure I'm following on the third bullet. I would think that formatted HTML should be treated as valid and supported content. So we shouldn't render at all the UnsupportedContent component, right? Are we too greedy in the validation of what's supported or not? |
packages/mgt-chat/src/statefulClient/GraphNotificationClient.ts
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/statefulClient/StatefulGraphChatClient.ts
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/statefulClient/StatefulGraphChatClient.ts
Outdated
Show resolved
Hide resolved
packages/mgt-chat/src/statefulClient/StatefulGraphChatClient.ts
Outdated
Show resolved
Hide resolved
packages/mgt-components/src/components/mgt-contact/mgt-contact.ts
Outdated
Show resolved
Hide resolved
packages/mgt-components/src/components/mgt-contact/mgt-contact.ts
Outdated
Show resolved
Hide resolved
packages/mgt-components/src/components/mgt-picker/mgt-picker.ts
Outdated
Show resolved
Hide resolved
packages/mgt-components/src/components/preview/mgt-search-box/mgt-search-box.ts
Outdated
Show resolved
Hide resolved
packages/mgt-components/src/components/preview/mgt-search-results/mgt-search-results.ts
Outdated
Show resolved
Hide resolved
🚀 New react-contoso sample application deployed here |
The auto-deployment of React Contoso on any PR is ABSOLUTELY FANTASTIC! Thanks for making this a thing @gavinbarron! |
Couple of things I saw, but might be related to the order of things.
|
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@sebastienlevert for point 1, they will be rendered as mgt person when that PR is merged. For point 2, I narrowed it down to:
I have fixed the issue and should be good to go. |
🚀 New react-contoso sample application deployed here |
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@musale I see that you have resolved the comments about all of the extra eslint suppressions but I'm not seeing that they have been removed. Is there a commit missing from this change? |
🚀 New react-contoso sample application deployed here |
…soft-graph-toolkit into unsupported-content
🚀 New react-contoso sample application deployed here |
packages/mgt-components/src/components/mgt-picker/mgt-picker.ts
Outdated
Show resolved
Hide resolved
🚀 New react-contoso sample application deployed here |
Closes #2190
PR Type
Description of the changes
Renders a CTA component showing the content is unsupported and you need to use the main window to view it.
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information