Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): mgt-file and mgt-picker visibility issues in dark-mode #2667

Merged
merged 22 commits into from
Oct 3, 2023
Merged

fix(a11y): mgt-file and mgt-picker visibility issues in dark-mode #2667

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e61168a
fix accessibility contrast
Mnickii Aug 16, 2023
b4130d6
Merge branch 'main' into bug-2318
Mnickii Aug 16, 2023
6611d40
fix placeholder hover
Mnickii Aug 16, 2023
3e6a9c0
Merge branch 'main' into bug-2318
Mnickii Aug 17, 2023
63b547e
Merge branch 'main' into bug-2318
Mnickii Aug 21, 2023
a34f988
remove login changes
Mnickii Aug 21, 2023
14cc8fd
adds pointer cursor to logged in accounts (#2674)
Mnickii Aug 22, 2023
26d327d
Merge branch 'main' into bug-2318
musale Aug 23, 2023
405f948
Merge branch 'main' into bug-2318
Mnickii Sep 5, 2023
3ef5595
fix build
Mnickii Sep 4, 2023
2bf426f
Merge branch 'main' into bug-2318
Mnickii Sep 18, 2023
4dba5e8
change picker-text-color
Mnickii Sep 18, 2023
8ccc8f8
update picker color, update file theme colors
Mnickii Sep 18, 2023
4627948
Merge branch 'main' into bug-2318
Mnickii Sep 19, 2023
fddb2d0
Merge branch 'main' into bug-2318
Mnickii Sep 21, 2023
84fb305
Merge branch 'main' into bug-2318
Mnickii Sep 25, 2023
44b57cb
Merge branch 'main' into bug-2318
Mnickii Sep 25, 2023
e01b9df
fix people picker colors, remove file-list box shadow
Mnickii Sep 25, 2023
8c47bc6
Merge branch 'main' into bug-2318
Mnickii Sep 28, 2023
3e9d414
Merge branch 'main' into bug-2318
gavinbarron Sep 28, 2023
59f2ddf
change placeholder color
Mnickii Oct 3, 2023
4181b01
Merge branch 'main' into bug-2318
gavinbarron Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/mgt-components/src/components/mgt-file/mgt-file.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ $line3-text-transform: var(--file-line3-text-transform, initial);
background-color: $file-background-color-hover;
border-radius: $file-border-radius;
cursor: pointer;

--secondary-text-color: var(--secondary-text-hover-color);
}

&:focus,
Expand Down
4 changes: 2 additions & 2 deletions packages/mgt-components/src/components/mgt-file/mgt-file.theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
*/

$line1-color: var(--file-line1-color, var(--neutral-foreground-rest));
$line2-color: var(--file-line2-color, var(--neutral-foreground-hint));
$line3-color: var(--file-line3-color, var(--neutral-foreground-hint));
$line2-color: var(--file-line2-color, var(--secondary-text-color));
$line3-color: var(--file-line3-color, var(--secondary-text-color));
$file-background-color: var(--file-background-color);
$file-background-color-focus: var(--file-background-color-focus, var(--neutral-fill-hover));
$file-background-color-hover: var(--file-background-color-hover, var(--neutral-fill-hover));
1 change: 1 addition & 0 deletions packages/mgt-components/src/components/mgt-login/mgt-login.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ $login-flyout-command-text-color: #{var(--login-flyout-command-text-color, var(-
margin-top: 4px;
background: $login-popup-background-color;
list-style-type: none;
cursor: pointer;

&:hover {
background: $login-account-item-hover-bg-color;
Expand Down
18 changes: 16 additions & 2 deletions packages/mgt-components/src/components/mgt-picker/mgt-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,25 @@

:host {
--max-height: var(--picker-max-height, 380px);

font-family: $font-family;

.picker {
.picker {
background-color: $picker-background-color;

fluent-combobox {
&::part(control) {
&::placeholder {
color: $picker-text-color;
}

&:hover {
&::placeholder {
color: $picker-text-hover-color;
}
}
}
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions packages/mgt-components/src/components/mgt-picker/mgt-picker.theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
@import '../../styles/shared-sass-variables';

$picker-background-color: var(--picker-background-color, transparent);
$picker-text-color: var(--picker-text-color, var(--secondary-text-color));
$picker-text-hover-color: var(--picker-text-color-hover, var(--secondary-text-hover-color));