Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache messages received via web sockets #2766

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: cache messages received via web sockets #2766

merged 1 commit into from
Oct 11, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2765

PR Type

  • Feature

Description of the changes

Adds code to update IndexDB when messages are received via web sockets

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner October 9, 2023 18:44
@gavinbarron gavinbarron linked an issue Oct 9, 2023 that may be closed by this pull request
[mgt-chat] Messages received via web sockets should be added to local cache to reduce server calls for reloads #2765
Closed
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🚀 New react-contoso sample application deployed here

sebastienlevert
sebastienlevert approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fully worked for me!

@gavinbarron gavinbarron merged commit 94bd50f into next/mgt-chat Oct 11, 2023
10 checks passed
@gavinbarron gavinbarron deleted the feat/cache-websocket-received-messages branch October 11, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

Assignees
No one assigned
Labels
Build: React Contoso
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mgt-chat] Messages received via web sockets should be added to local cache to reduce server calls for reloads
2 participants
@gavinbarron @sebastienlevert