Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add edit funtionality to mgt-todo #2783

Merged
merged 37 commits into from
Dec 1, 2023
Merged

feat: add edit funtionality to mgt-todo #2783

merged 37 commits into from
Dec 1, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Oct 17, 2023 •
edited
Loading

Closes #2161

PR Type

Feature

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@github-actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions
Copy link

📖 The updated storybook is available here

@github-actions
Copy link

📖 The updated storybook is available here

@github-actions
Copy link

📖 The updated storybook is available here

@github-actions
Copy link

🚀 New react-contoso sample application deployed here

@Mnickii
rewrite edit option to apply focus on input element, remove the fluen…
7fff785 
…t-checkbox wrapper on todo tasks, fix k@keydown function, add Radio svg to fix incomplete checkbox
@github-actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions
Copy link

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from gavinbarron October 25, 2023 16:46
@Mnickii Mnickii marked this pull request as ready for review October 25, 2023 16:46
@Mnickii Mnickii requested a review from a team as a code owner October 25, 2023 16:46
@github-actions
Copy link

📖 The updated storybook is available here

@github-actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions
Copy link

📖 The updated storybook is available here

musale
musale reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@musale musale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mnickii I shouldn't be able to edit a completed todo.

UPDATE: I could update in the todos web app a completed todo. As it is, it's in line with the app behavior.

@gavinbarron
Copy link
Member

@Mnickii if a task is entered without a due date then it is not possible to add a due date. We really should be able to add a due date at any time.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

🚀 New react-contoso sample application deployed here

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

🚀 New react-contoso sample application deployed here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Nov 30, 2023
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 51% 100% 0 ➖
mgt-components.src.components.mgt-file-list 56% 100% 0 ➖
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0 ❌
mgt-components.src.components.mgt-get 30% 100% 0 ❌
mgt-components.src.components.mgt-messages 66% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 81% 65% 0 ✔
mgt-components.src.components.mgt-person-card 66% 47% 0 ➖
mgt-components.src.components.mgt-picker 78% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 77% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-arrow-options 71% 100% 0 ➖
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 89% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 73% 79% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 77% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 72% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 66% 69% 0 ➖
mgt-element.src 88% 100% 0 ✔
mgt-element.src.components 84% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 80% 85% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 66% (14090 / 21364) 64% (425 / 659) 0 ➖

sebastienlevert
sebastienlevert approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected!

@gavinbarron gavinbarron enabled auto-merge (squash) December 1, 2023 16:32
@gavinbarron
Copy link
Member

Great work to get this over the line @Mnickii, thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 80% 100% 0 ✔
mgt-components.src.components.mgt-contact 63% 100% 0 ➖
mgt-components.src.components.mgt-file 51% 100% 0 ➖
mgt-components.src.components.mgt-file-list 56% 100% 0 ➖
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0 ❌
mgt-components.src.components.mgt-get 30% 100% 0 ❌
mgt-components.src.components.mgt-messages 66% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 81% 65% 0 ✔
mgt-components.src.components.mgt-person-card 64% 50% 0 ➖
mgt-components.src.components.mgt-picker 78% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 77% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-arrow-options 71% 100% 0 ➖
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 89% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 19% 0 ✔
mgt-element.dist.es6.components.src.components 73% 80% 0 ➖
mgt-element.dist.es6.mock.src.mock 90% 72% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 69% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 66% 69% 0 ➖
mgt-element.src 88% 100% 0 ✔
mgt-element.src.components 84% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 80% 85% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 66% (14020 / 21364) 64% (412 / 646) 0 ➖

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 64acd1f into main Dec 1, 2023
9 checks passed
@gavinbarron gavinbarron deleted the feat/edit-todos branch December 1, 2023 17:29
@gavinbarron gavinbarron mentioned this pull request Dec 1, 2023
Merged
@gavinbarron gavinbarron mentioned this pull request Feb 5, 2024
Merged
This was referenced Jun 8, 2024
Open
Open
This was referenced Jun 20, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@gavinbarron gavinbarron gavinbarron approved these changes

@musale musale Awaiting requested review from musale

Assignees
No one assigned
Labels
Build: React Contoso Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mgt-todo] Allow editing of todos
4 participants
@Mnickii @gavinbarron @sebastienlevert @musale