Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: membership management button stacking #2785

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2777

Depends on #2779

PR Type

  • Bugfix

Description of the changes

stacks buttons in popover vertically
updates button in popover to use the subtle appearance as this provides a visible hover state that more closely aligns with the Teams client
updates layout of member list to use correct padding
removes Button from the ListItem as it was creating a weird experience when navigating with a keyboard where you had to press the arrow key twice for each ListItem
adds styling to show the dismiss icon when navigating with a keyboard
closes the dialog when activating the ListItem for the current user to mimic the behavior in Teams

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner October 17, 2023 21:41
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

🚀 New react-contoso sample application deployed here

musale
musale previously approved these changes Oct 18, 2023
@gavinbarron gavinbarron dismissed stale reviews from sebastienlevert and musale via a337feb October 18, 2023 18:00
@gavinbarron gavinbarron enabled auto-merge (squash) October 18, 2023 18:03
@github-actions
Copy link

🚀 New react-contoso sample application deployed here

@gavinbarron gavinbarron merged commit 80a6d07 into next/mgt-chat Oct 18, 2023
8 checks passed
@gavinbarron gavinbarron deleted the fix/chat-member-button-stacking branch October 18, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants