Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: getUserPresence should only request presence.read #2813

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Oct 30, 2023

Closes #2808

PR Type

  • Bugfix

Description of the changes

BREAKING CHANGE: applications which have previously requested presence.read.all and not presence.read will have a changed set of required scopes. This will require additional user consent or updating of pre-consented permissions when incremental consent is not enabled

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

BEGIN_COMMIT_OVERRIDE
chore: change reverted due to testing error and invalid change
END_COMMIT_OVERRIDE

BREAKING CHANGE: applications which have previously requested presence.read.all and not presence.read will have a changed set of required scopes. This will require additional user consent or updating of pre-consented permissions when incremental consent is not enabled
@gavinbarron gavinbarron requested a review from a team as a code owner October 30, 2023 22:56
@gavinbarron gavinbarron enabled auto-merge (squash) October 31, 2023 18:36
@gavinbarron gavinbarron merged commit 14e7a56 into main Oct 31, 2023
8 checks passed
@gavinbarron gavinbarron deleted the fix/get-user-presence-permission branch October 31, 2023 18:41
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 64% 38% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 28% 0
mgt-element.dist.es6.components.src.components 73% 79% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (12446 / 19095) 63% (405 / 638) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-person with presence should be using Presence.Read
3 participants