Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an ellipsis link that redirects to teams web on click #2816

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Oct 31, 2023

Closes #2773

PR Type

  • Feature

Description of the changes

Adds an ellipsis on group and one on one chats that has a link to the chat on the teams web/app.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@musale musale added this to the Chat - Public Preview milestone Oct 31, 2023
@musale musale requested a review from a team as a code owner October 31, 2023 16:34
Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
Copy link

🚀 New react-contoso sample application deployed here

@gavinbarron
Copy link
Member

Sidenote comment the latest designs are here: https://www.figma.com/file/gP4q8VQ2so2ftzKz4GCuVh/Microsoft-Graph-Toolkit-(WIP)?node-id=11213%3A30025&mode=dev

The aka link is pointing at outdated designs now

@gavinbarron gavinbarron linked an issue Oct 31, 2023 that may be closed by this pull request
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Copy link

github-actions bot commented Nov 2, 2023

🚀 New react-contoso sample application deployed here

2 similar comments
Copy link

github-actions bot commented Nov 2, 2023

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Nov 2, 2023

🚀 New react-contoso sample application deployed here

@sebastienlevert
Copy link
Contributor

The aka.ms link was updated

@gavinbarron gavinbarron enabled auto-merge (squash) November 3, 2023 18:11
Copy link

github-actions bot commented Nov 3, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-chat.src.statefulClient 100% 100% 0
mgt-chat.src.utils 100% 94% 0
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 64% 38% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 39% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 28% 0
mgt-element.dist.es6.components.src.components 73% 79% 0
mgt-element.dist.es6.mock.src.mock 90% 67% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (12596 / 19271) 64% (419 / 653) 0

Copy link

github-actions bot commented Nov 3, 2023

🚀 New react-contoso sample application deployed here

@gavinbarron gavinbarron merged commit a11fc65 into next/mgt-chat Nov 3, 2023
9 checks passed
@gavinbarron gavinbarron deleted the teams-ellipsis branch November 3, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[mgt-chat] Add navigate to teams ellipsis button
4 participants