-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add aria-label text string for teams chevrons #3129
Conversation
📖 The updated storybook is available here |
I can't close opened teams now. Is this a defect from this PR now? |
I don't think so. Is it different behavior from mgt.dev? |
packages/mgt-components/src/components/mgt-teams-channel-picker/strings.ts
Show resolved
Hide resolved
📖 The updated storybook is available here |
@Raisul123 could you please validate this fix? |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
Hi @gavinbarron , This issue not repro on below URL |
@Raisul123 can you offer any insight as to why adding the aria-label does not resolve this issue> |
Hi @gavinbarron, We have added tag A11yTTValidated on #3050 which is related to this PR also, same reference was provide by Raisul on this PR as well. Please let me know if you need any help on this PR. |
@Raisul123 and @vagpt, my apologies, I mis-read your comment. |
📖 The updated storybook is available here |
|
Closes #3050
PR Type
Description of the changes
Adds 2 aria label strings for chevron up and down buttons.
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information