-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): focus on uploaded file and narrate status #3189
Conversation
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
@vagpt review this for a11y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use uploadDom as a HTMLElement to be able to call focus() on it.
packages/mgt-components/src/components/mgt-file-list/mgt-file-upload/mgt-file-upload.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Nickii Miaro <miaronkirote@gmail.com>
📖 The updated storybook is available here |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
This issue is still repro on the URL below. Attachment is added for the reference. URL: https://mgt.dev/next/pr/3189/?path=/story/components-mgt-file-list-properties--file-list-upload Attachment: Issue.is.still.repro.at.SR.is.still.not.announicng.any.infomration.mp4 |
📖 The updated storybook is available here |
@vagpt please hard reload and test again, re-tested locally and on the link, it does focus on the uploaded file. |
📖 The updated storybook is available here |
|
This issue is now working as expected hence we are good to close it related bug. Attachment - Untitled.video.-.Made.with.Clipchamp.22.mp4 |
Closes #3110
PR Type
Description of the changes
Created custom events to be fired on successful or failed file upload attempts
Focus on the uploaded file
Set aria-label text to narrate the file name and status of upload
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information