Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): narrate person list position in mgt-agenda #3221

Merged
merged 11 commits into from
Jul 1, 2024
Merged

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 13, 2024

Closes #3080

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii marked this pull request as draft June 14, 2024 09:55
@Mnickii Mnickii marked this pull request as ready for review June 18, 2024 15:25
@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 19, 2024

@Raisul123 @vagpt this is ready for testing

@musale
Copy link
Contributor

musale commented Jun 20, 2024

@Mnickii I've tested this, and it doesn't announce the position. It still says "group." Is it supposed to say, "Photo for Adele Vance, position one"?

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 20, 2024

@musale are you testing the people list? It doesn't say group. Yes, it should announce the position of the person in the list. Try refresh and test it again.

@Mnickii Mnickii requested a review from musale June 24, 2024 15:11
@vagpt
Copy link
Collaborator

vagpt commented Jun 25, 2024

@Mnickii

This issue is still repro'ing on the URL below as SR is still announcing as Group.

URL - https://mgt.dev/next/pr/3221/?path=/docs/components-mgt-agenda--docs

Attachments:

SR.is.still.announcing.as.Group.mp4

Copy link

📖 The updated storybook is available here

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Swastika7
Copy link

@Mnickii
This issue is fixed on URL below , hence we are good to close the bug related to this PR.
image

@Mnickii Mnickii merged commit 463687d into main Jul 1, 2024
10 of 11 checks passed
@Mnickii Mnickii deleted the fix/bug-3080 branch July 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants