Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add padding to the list of direct reports in person-card #3265

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jul 31, 2024

Closes #3261

PR Type

  • Bugfix

Description of the changes

Added a 4px padding, top and bottom of elements in the direct reports list.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

image

@musale musale requested a review from a team as a code owner July 31, 2024 13:18
Copy link

📖 The updated storybook is available here

Copy link

@musale musale merged commit 8036278 into main Aug 1, 2024
13 checks passed
@musale musale deleted the fix/add-report-padding branch August 1, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Person card - Insufficient padding in Direct reports
2 participants