Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the css query and events used to rename copy button aria-labels #3271

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Aug 6, 2024

Closes #3076

PR Type

  • Bugfix

Description of the changes

  • Use scroll event to get the copy buttons used in code blocks
  • Update the aria-label text to mention the header text

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the 4.2.5 milestone Aug 6, 2024
@musale musale requested a review from a team as a code owner August 6, 2024 16:26
.storybook/components/ElementNamer.jsx Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback Issue needs response from issue author and removed Needs: Author Feedback Issue needs response from issue author labels Aug 7, 2024
Co-authored-by: Nickii Miaro <miaronkirote@gmail.com>
@musale musale requested a review from Mnickii August 7, 2024 10:43
Copy link

github-actions bot commented Aug 7, 2024

📖 The updated storybook is available here

Copy link

sonarqubecloud bot commented Aug 7, 2024

Copy link
Collaborator

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musale musale merged commit 439d0fc into main Aug 12, 2024
11 checks passed
@musale musale deleted the fix/a11y-append-copytxt branch August 12, 2024 07:41
@musale
Copy link
Contributor Author

musale commented Aug 12, 2024

@Raisul123 I closed this before you tested it out, my bad. Please use the next link https://mgt.dev/next/ to test if this is fixed. If not, comment on this PR and I'll re-open the issue and post a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants