Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display contact icons with personDetails #3276

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Aug 21, 2024

Closes #3229

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner August 21, 2024 11:15
Co-authored-by: Musale Martin <martinmusale@microsoft.com>
Copy link

📖 The updated storybook is available here

Copy link

@Mnickii Mnickii requested a review from musale August 28, 2024 12:21
@musale musale merged commit e685aee into main Aug 28, 2024
11 checks passed
@musale musale deleted the fix/person-card-contact-icons branch August 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] person-card: buttons not working when using person-details
2 participants